Re: Add new option 'all' to pg_stat_reset_shared()

torikoshia <torikoshia@oss.nttdata.com>

From: torikoshia <torikoshia@oss.nttdata.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Andres Freund <andres@anarazel.de>, boekewurm+postgres@gmail.com, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@postgresql.org, bharath.rupireddyforpostgres@gmail.com

Date: 2023-11-15T02:58:38Z

Lists: pgsql-hackers

Attachments

v2-0001-Add-ability-to-reset-pg_stat_slru-in-pg_stat_rese.patch (text/x-diff) patch v2-0001

On 2023-11-15 09:47, Michael Paquier wrote:
> On Tue, Nov 14, 2023 at 10:02:32PM +0900, torikoshia wrote:
>> Attached patch.
> 
> You have forgotten to update the errhint at the end of
> pg_stat_reset_shared(), where "slru" needs to be listed :)

Oops, attached v2 patch.

>> BTW currently the documentation explains all the arguments of
>> pg_stat_reset_shared() in one line and I feel it's a bit hard to read.
>> Attached patch uses <itemizedlist>.
> 
> Yes, this one is a good idea because each target works on a different
> system view so it becomes easier to understand what a target affects,
> so I've applied this bit, without the slru addition.

Thanks!

> --
> Michael

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA Group Corporation

Commits

Add target "slru" to pg_stat_reset_shared()
- 2e8a0edc2a33 17.0 landed
doc: Improve description of targets for pg_stat_reset_shared()
- 7f6bc3b35678 17.0 landed
Add support for pg_stat_reset_slru without argument
- e5cca6288a40 17.0 landed
Add ability to reset all shared stats types in pg_stat_reset_shared()
- 23c8c0c8f472 17.0 landed