Horton

Re: Cleanup: remove unused fields from nodes

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Etsuro Fujita <etsuro.fujita@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>
Date: 2024-04-24T03:03:40Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Apr 23, 2024 at 01:01:04PM -0400, Tom Lane wrote:
>> That is, query jumbling no longer distinguishes "DEALLOCATE x" from
>> "DEALLOCATE ALL", because the DeallocateStmt.name field is marked
>> query_jumble_ignore.  Now maybe that's fine, but it's a point
>> we'd not considered so far in this thread.  Thoughts?

> And of course, I've managed to forget about bb45156f342c and the
> reason behind the addition of the field is to be able to make the
> difference between the named and ALL cases for DEALLOCATE, around
> here:
> https://www.postgresql.org/message-id/ZNq9kRwWbKzvR%2B2a%40paquier.xyz

Hah.  Seems like the comment for isall needs to explain that it
exists for this purpose, so we don't make this mistake again.

			regards, tom lane

Commits

  1. Improve comment of DeallocateStmt->isall

  2. Remove some unnecessary fields from executor nodes.

  3. Add SQL/JSON query functions

  4. Add support for doing late row locking in FDWs.