Re: "make check" with non-GNU make
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-08-09T15:25:34Z
Lists: pgsql-hackers
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Wed, Aug 9, 2017 at 3:44 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hmm, looking into Makefile.global.in, that step seems to be conditional on
>> MAKELEVEL:
> Ah, right. That coding is recommended in the GNU make manual to
> distinguish from explicit invocation and recursive invocation.
> FreeBSD make also seems to set MAKELEVEL.
Oh, that would do it.
> Doing this fixes the
> problem for me, though it feels a bit sneaky:
> - $${GMAKE} $@ ; \
> + MAKELEVEL= $${GMAKE} $@ ; \
Seems like a reasonable fix to me.
regards, tom lane
Commits
-
Prevent passing down MAKELEVEL/MAKEFLAGS from non-GNU make to GNU make.
- a784d5f215ff 9.5.9 landed
- fc2aafe4a55b 9.6.5 landed
- a76200de8462 10.0 landed