Horton

Re: pg_dumpall with flag --no-role-passwords omits roles comments as well

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Bartosz Chroł <bartosz.chrol@handen.pl>, "pgsql-general@postgresql.org" <pgsql-general@postgresql.org>
Date: 2024-03-21T23:23:15Z
Lists: pgsql-general 
> On 21 Mar 2024, at 14:27, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> 
> On 2024-Mar-21, Daniel Gustafsson wrote:
> 
>> On 21 Mar 2024, at 13:28, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>> 
>>> I very much doubt that they realized that comments were going to be
>>> omitted.  But clearly it's just a mistake, and easily fixed.
>> 
>> It sure looks like a search/replace kind of bug.  I had just typed up the exact
>> same patch with the addition of a comment on why pg_authid is used and was
>> about to hit send when your email came =) Are you committing it or do you want
>> me to take care of it?
> 
> Hah :-)  Please do.

Done, backpatched all the way since it's been broken since 2017.

--
Daniel Gustafsson

Commits

  1. Fix dumping role comments when using --no-role-passwords