Re: Dubious usage of TYPCATEGORY_STRING
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-12-07T20:24:46Z
Lists: pgsql-hackers
Attachments
- 0001-dont-put-special-purpose-types-in-string-category-2.patch (text/x-diff) patch 0001
I wrote: > Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes: >> Could we add explicit casts (like polcmd::text) here? Or would it break >> too much? > I assumed it'd break too much to consider doing that. But I suppose > that since a typcategory change would be initdb-forcing anyway, maybe > it's not out of the question. I'll investigate and see exactly how > many places would need an explicit cast. Um, I definitely gave up too easily there. The one usage in \dp seems to be the *only* thing that breaks in describe.c, and pg_dump doesn't need any changes so far as check-world reveals. So let's just move "char" to another category, as attached. regards, tom lane
Commits
-
Create a new type category for "internal use" types.
- 07eee5a0dc64 15.0 landed