Re: Possible typo/unclear comment in joinpath.c
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: James Coleman <jtc331@gmail.com>, pgsql-hackers@postgresql.org
Date: 2021-04-14T18:32:40Z
Lists: pgsql-hackers
I wrote: > Justin Pryzby <pryzby@telsasoft.com> writes: >> It looks like a loose end from >> commit edca44b1525b3d591263d032dc4fe500ea771e0e > Yeah :-(. I'm usually pretty careful about grepping for comment > references as well as code references to a field when I do something > like that, but obviously I missed that step that time. No, I take that back. There were no references to extra_lateral_rels after that commit; these comments were added by 45be99f8c, about six weeks later. The latter was a pretty large patch and had presumably been under development for quite some time, so the comments were probably accurate when written but didn't get updated. regards, tom lane
Commits
-
Fix obsolete comments referencing JoinPathExtraData.extra_lateral_rels.
- e1623b7d8681 14.0 landed
-
Simplify LATERAL-related calculations within add_paths_to_joinrel().
- edca44b1525b 9.6.0 cited