Re: Enable -Wstrict-prototypes and -Wold-style-definition by default

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Peter Eisentraut <peter@eisentraut.org>

Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2026-03-23T15:20:39Z

Lists: pgsql-hackers

Peter Eisentraut <peter@eisentraut.org> writes:
> I have a couple of follow-up patches that I had developed while playing 
> with this.

I'm not in a position to evaluate the MSVC-specific changes, but
+1 for the other two.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add warning option -Wold-style-declaration
- c73e8ee061ad 19 (unreleased) landed
configure: Apply -Werror=vla to C++ as well as C
- 488ab592d9ea 19 (unreleased) landed
Enable warning like -Wstrict-prototypes on MSVC as well
- b4a132022444 19 (unreleased) landed
Remove compiler warning option -Wendif-labels
- 87e1891c459e 19 (unreleased) landed
Disable warnings in system headers in MSVC
- bccfc73acde9 19 (unreleased) landed
Fix -Wstrict-prototypes warning in ecpg_init_sqlca() declaration.
- f91b8ff6af91 19 (unreleased) landed