Re: Another regexp performance improvement: skip useless paren-captures

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Mark Dilger <mark.dilger@enterprisedb.com>

Cc: Andrew Dunstan <andrew@dunslane.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Joel Jacobson <joel@compiler.org>

Date: 2021-08-24T18:29:01Z

Lists: pgsql-hackers

Mark Dilger <mark.dilger@enterprisedb.com> writes:
> I've beaten on this with random patterns and it seems to hold up just fine.  I have also reviewed the diffs and, for the patterns where the output changes, everything looks correct.  I can't find anything wrong with this patch.

Thanks for testing!  I'll push it in a bit.

			regards, tom lane

Commits

Fix regexp misbehavior with capturing parens inside "{0}".
- 92620e82f6a1 12.9 landed
- 7e75fe390b68 9.6.24 landed
- 3ebd32e70c09 11.14 landed
- 244dd79923a1 14.0 landed
- 071146184a59 13.5 landed
- 062c4c791937 10.19 landed
- 65dc30ced64c 15.0 landed
Let regexp_replace() make use of REG_NOSUB when feasible.
- 18bac60ede44 15.0 landed
Fix bogus assertion in BootstrapModeMain().
- e12694523e7e 15.0 cited
Avoid determining regexp subexpression matches, when possible.
- 0e6aa8747d43 15.0 landed
Check the size in COPY_POINTER_FIELD
- c1132aae336c 15.0 cited
Make regexp engine's backref-related compilation state more bulletproof.
- cb76fbd7ec87 15.0 cited