Re: Remove MSVC scripts from the tree

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>

To: Peter Eisentraut <peter@eisentraut.org>, Michael Paquier <michael@paquier.xyz>

Cc: NINGWEI CHEN <chen@sraoss.co.jp>, pgsql-hackers@lists.postgresql.org, buildfarm@sraoss.co.jp

Date: 2023-12-06T20:52:10Z

Lists: pgsql-hackers

On 2023-12-06 We 12:24, Peter Eisentraut wrote:
> On 06.12.23 17:27, Andrew Dunstan wrote:
>> But the VS2019 compiler implements enough of C99 to pass our meson 
>> test, unlike VS2017. Maybe the test is too strict. After all, we know 
>> we can in fact build with the earlier versions.
>
> I just realized that the C99 test is actually our own, not provided by 
> meson.  (See "c99_test" in meson.build.)
>
> Can you try disabling a few bits of that to see what makes it pass for 
> you?  I suspect it's the structfunc() call.


Yes, if I comment out the call to structfunc() the test passes on VS2017 
(compiler version 19.15.26726)


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

Make win32tzlist.pl checkable again
- 8ddf9c1dc020 17.0 landed
meson: Make gzip and tar optional
- 9ca6e7b9411e 17.0 landed
meson: Make sed optional
- 9aa374dcfb76 17.0 landed
Remove MSVC scripts
- 1301c80b2167 17.0 landed
Replace Gen_dummy_probes.sed with Gen_dummy_probes.pl
- 3849fe7c2ba7 17.0 landed