Horton
Menu

Re: run pgindent on a regular basis / scripted manner

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Date: 2020-08-15T11:47:41Z
Lists: pgsql-hackers 
On 2020-08-13 00:34, Andres Freund wrote:
> I e.g. just re-indented patch 0001 of my GetSnapshotData() series and
> most of the hunks were entirely unrelated. Despite the development
> window for 14 having only relatively recently opened. Based on my
> experience it tends to get worse over time.

Do we have a sense of why poorly-indented code gets committed?  I think 
some of the indentation rules are hard to follow manually.  (pgperltidy 
is worse.)

Also, since pgindent gets run eventually anyway, it's not really that 
important to get the indentation right the first time.  I suspect the 
goal of most authors and committers is to write readable code rather 
than to divine the exact pgindent output.

I think as a start, we could just issue a guidelines that all committed 
code should follow pgindent.  That has never really been a guideline, so 
it's not surprising that it's not followed.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix comment from commit 22655aa231.

  2. Add a few recent commits to .git-blame-ignore-revs.

  3. Pre-beta2 mechanical code beautification.

  4. Pre-beta mechanical code beautification.

  5. Make agreed-on updates in perltidy options.

  6. Remove obsolete pgindent options --code-base and --build

  7. Integrate pg_bsd_indent into our build/test infrastructure.

  8. Sync pg_bsd_indent's copyright notices with Postgres practice.

  9. Import pg_bsd_indent sources.

  10. pgindent: filter files for the --commit option

  11. pgindent: more ways to find files to indent

  12. Fix pgindent --show-diff option.

  13. Add non-destructive modes to pgindent

  14. Initial pgindent run with pg_bsd_indent version 2.0.