Thread

Re: Error messages/logging (Was: Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/parser gram.y parse_oper.c')

Vadim B. Mikheev <vadim@sable.krasnoyarsk.su> — 1998-01-05T03:35:10Z

Bruce Momjian wrote:
> 
> >
> > Mattias Kregert wrote:
> > >
> > > Bruce Momjian wrote:
> > > >
> > >
> > > > I just think the WARN word coming up on users terminals is odd.  I can
> > > > make the change in all the source files easily if we decide what the new
> > > > error word should be.  Error?  Failure?
> > > >
> > >
> > > Yes, that's one of the things I don't understand with PostgreSQL.
> > > ERROR would be much better.
> >
> > How about ABORT ?
> 
> Sounds maybe a little too serious.  We currently use WARN a lot to
> indicate errors in the supplied SQL statement.  Perhaps we need to make
> the parser elog's ERROR, and the non-parser WARN's ABORT?  Is that good?
> When can I make the change?  I don't want to mess up people's current work.

ABORT means that transaction is ABORTed.
Will ERROR mean something else ?
Why should we use two different flag-words for the same thing ?
Note, that I don't object against using ERROR, but against using two words.

Vadim