Horton

Re: fix typos

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Erik Rijkers <er@xs4all.nl>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-04T13:41:05Z
Lists: pgsql-hackers 
John Naylor <john.naylor@enterprisedb.com> writes:
> On Tue, Aug 2, 2022 at 1:11 AM Justin Pryzby <pryzby@telsasoft.com> wrote:
>   ereport(ERROR,
>   (errcode(ERRCODE_OBJECT_IN_USE),
> - errmsg("could not drop replication origin with OID %d, in use by PID %d",
> + errmsg("could not drop replication origin with OID %u, in use by PID %d",

> RepOriginId is a typedef for uint16, so this can't print the wrong answer,
> but it is inconsistent with other uses. So it seems we don't need to
> backpatch this one?

Um ... if it's int16, then it can't be an OID, so I'd say this message has
far worse problems than %d vs %u.  It should not use that terminology.

			regards, tom lane

Commits

  1. Fix formatting and comment typos

  2. Fix assorted doc typos

  3. Clarify DROP EXTENSION docs regarding explicitly dependent routines

  4. doc: clarify how dropping of extensions affects dependent objs.

  5. Move remaining code from tqual.[ch] to heapam.h / heapam_visibility.c.