Horton

Re: unite recovery.conf and postgresql.conf

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joshua Berkus <josh@agliodbs.com>
Cc: Tatsuo Ishii <ishii@postgresql.org>, pgsql-hackers@postgresql.org, Robert Haas <robertmhaas@gmail.com>
Date: 2011-09-25T18:05:29Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Restructure error handling in reading of postgresql.conf.

Joshua Berkus <josh@agliodbs.com> writes:
> What happens currently if we have an \include in postgresql.conf for a file which doesn't exist?  Is it ignored, or do we error out?

It's an error, and I think changing that would be a really bad idea.

> If it could just be ignored, maybe with a note in the logs, then we could be a lot more flexible.

There might be a use case for a separate directive include_if_exists,
or some such name.  But I think the user should have to tell us very
clearly that it's okay for the file to not be found.

			regards, tom lane