Horton
Menu

Re: run pgindent on a regular basis / scripted manner

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Jelte Fennema <postgres@jeltef.nl>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, Robert Haas <robertmhaas@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>, Peter Geoghegan <pg@bowt.ie>, Bruce Momjian <bruce@momjian.us>, Magnus Hagander <magnus@hagander.net>, Alvaro Herrera <alvherre@2ndquadrant.com>, Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2023-04-26T19:44:47Z
Lists: pgsql-hackers 
On 2023-04-26 We 09:27, Tom Lane wrote:
> Peter Eisentraut<peter.eisentraut@enterprisedb.com>  writes:
>> On 24.04.23 16:14, Tom Lane wrote:
>>> I certainly don't like its current behavior where adding/changing one
>>> line can have side-effects on nearby lines.  But we have a proposal
>>> to clean that up, and I'm cautiously optimistic that it'll be better
>>> in future.  Did you have other specific concerns?
>> I think the worst is how it handles multi-line data structures like
>>           $newnode->command_ok(
>>               [
>>                   'psql', '-X',
>>                   '-v',   'ON_ERROR_STOP=1',
>>                   '-c',   $upcmds,
>>                   '-d',   $oldnode->connstr($updb),
>>               ],
>>               "ran version adaptation commands for database $updb");
> Yeah, I agree, there is no case where that doesn't suck.  I don't
> mind it imposing specific placements of brackets and so on ---
> that's very analogous to what pgindent will do.  But it likes to
> re-flow comma-separated lists, and generally manages to make a
> complete logical hash of them when it does, as in your other
> example:
>
>>           $node->command_fails_like(
>>               [
>>                   'pg_basebackup',   '-D',
>>                   "$tempdir/backup", '--compress',
>>                   $cft->[0]
>>               ],
>>               qr/$cfail/,
>>               'client ' . $cft->[2]);
> Can we fix it to preserve the programmer's choices of line breaks
> in comma-separated lists?



I doubt there's something like that. You can freeze arbitrary blocks of 
code like this (from the manual)


#<<<  format skipping: do not let perltidy change my nice formatting
         my @list = (1,
                     1, 1,
                     1, 2, 1,
                     1, 3, 3, 1,
                     1, 4, 6, 4, 1,);
#>>>


But that gets old and ugly pretty quickly.

There is a --freeze-newlines option, but it's global. I don't think we 
want that.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix comment from commit 22655aa231.

  2. Add a few recent commits to .git-blame-ignore-revs.

  3. Pre-beta2 mechanical code beautification.

  4. Pre-beta mechanical code beautification.

  5. Make agreed-on updates in perltidy options.

  6. Remove obsolete pgindent options --code-base and --build

  7. Integrate pg_bsd_indent into our build/test infrastructure.

  8. Sync pg_bsd_indent's copyright notices with Postgres practice.

  9. Import pg_bsd_indent sources.

  10. pgindent: filter files for the --commit option

  11. pgindent: more ways to find files to indent

  12. Fix pgindent --show-diff option.

  13. Add non-destructive modes to pgindent

  14. Initial pgindent run with pg_bsd_indent version 2.0.