Horton

Re: PL/R regression on windows, but not linux with master.

Joe Conway <mail@joeconway.com>

View thread View on postgr.es
From: Joe Conway <mail@joeconway.com>
To: Dave Cramer <davecramer@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>, Tomas Vondra <tomas.vondra@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-04-11T16:55:08Z
Lists: pgsql-hackers 
On 4/11/21 12:51 PM, Dave Cramer wrote:
> 
> 
> On Sun, 11 Apr 2021 at 12:43, Tom Lane <tgl@sss.pgh.pa.us 
> <mailto:tgl@sss.pgh.pa.us>> wrote:
> 
>     I wrote:
>      > Joe Conway <mail@joeconway.com <mailto:mail@joeconway.com>> writes:
>      >> Would an equivalent "PGWARNING" be something we are open to adding and
>      >> back-patching?
> 
>      > It's not real obvious how pl/r could solve this in a reliable way
>      > otherwise, so adding that would be OK with me, but I wonder whether
>      > back-patching is going to help you any.  You'd still need to compile
>      > against older headers I should think.  So I'd suggest
>      > (1) add PGWARNING in HEAD only
> 
>     Concretely, maybe like the attached?
> 
> 
> +1 from me.
> I especially like the changes to the comments as it's more apparent what they 
> should be used for.

+1

Looks great to me.

Joe

-- 
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development

Commits

  1. Add macro PGWARNING, and make PGERROR available on all platforms.