Re: Deprecating postfix and factorial operators in PostgreSQL 13
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>,
John Naylor <john.naylor@2ndquadrant.com>,
Vik Fearing <vik@postgresfriends.org>,
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Date: 2020-08-28T15:56:26Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes: > So, in this version, there are six copies of the deprecation notice > John wrote, rather than just one. Maybe we need more than one, but I > doubt we need six. I don't think the CREATE OPERATOR documentation > needs to mention this both when first introducing the concept and then > again when defining right_type; the former seems sufficient. I don't > think xoper.sgml needs these changes either; they interrupt the flow > of the narrative and I don't think this is where anyone would look for > a deprecation notice. I would also argue for dropping the mentions in > the docs for ALTER OPERATOR FAMILY and CREATE OPERATOR CLASS, although > those seem less clear-cut. Really, CREATE OPERATOR where John had it > originally seems like the right place. Yeah, I agree that there are way too many copies here. CREATE OPERATOR seems sufficient. It also seems like we should just rewrite the typeconv and drop_operator examples to use some other operator. We'll have to do that eventually anyway, so why not now, instead of visiting those places twice? regards, tom lane
Commits
-
Mark factorial operator, and postfix operators in general, as deprecated.
- cc8a71e93084 9.5.24 landed
- d1ee6ce4c9ff 11.10 landed
- 9dee85b5b833 12.5 landed
- 1f38d3851190 10.15 landed
- 1ce20826ce80 9.6.20 landed
- 845cfe012fd1 13.0 landed
- 6ca547cf75ef 14.0 landed