Re: pageinspect: Hash index support

On 09/20/2016 03:19 AM, Michael Paquier wrote:
> You did not get right the comments from Alvaro upthread. The following
> functions are added with this patch:
>  function hash_metap(text)
>  function hash_metap_bytea(bytea)
>  function hash_page_items(text,integer)
>  function hash_page_items_bytea(bytea)
>  function hash_page_stats(text,integer)
>  function hash_page_stats_bytea(bytea,integer)
>
> Now the following set of functions would be sufficient:
> function hash_metapage_info(bytea)
> function hash_page_items(bytea)
> function hash_page_stats(bytea)
> The last time pageinspect has been updated, when BRIN functions have
> been added, it has been discussed to just use (bytea) as an argument
> interface and just rely on get_raw_page() to get the pages wanted, so
> I think that we had better stick with that and keep things simple.
>

Yes, I know, Alvaro and you voted for the bytea methods, and Jeff asked 
for both.

Attached is v3 with only the bytea based methods.

Alvaro, Michael and Jeff - Thanks for the review !

Best regards,
  Jesper