Horton

Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

View thread View on postgr.es
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Michael Paquier <michael@paquier.xyz>
Cc: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>, Luis Carril <luis.carril@swarm64.com>, "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>, PG Bug reporting form <noreply@postgresql.org>
Date: 2018-12-19T01:30:07Z
Lists: pgsql-bugs 
On 2018/12/19 10:24, Amit Langote wrote:
> which is what I was thinking.  Instead of specifically preventing
> partitioned tables, or foreign tables, or views, we could assert that only
> relations having heap files are passed.

Sorry, that's not what I'd said in my last email.  I'd said we should add
guards so that it becomes a no-op for unsupported relkinds, which is not
the same thing as the above, so maybe we shouldn't do that.  We should fix
the callers so that heap_sync is called only for heap relations.  So, the
patch posted by Luis is on a good path.

Thanks,
Amit

Commits

  1. Disable WAL-skipping optimization for COPY on views

  2. Disable WAL-skipping optimization for COPY on views and foreign tables