Horton

Re: array_cat anycompatible change is breaking xversion upgrade tests

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>, Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@lists.postgresql.org, Bruce Momjian <bruce@momjian.us>
Date: 2022-06-24T14:06:53Z
Lists: pgsql-hackers 
Justin Pryzby <pryzby@telsasoft.com> writes:
> I realized that my latest patch would break upgrades from old servers, which do
> not have array_position/s nor width_bucket, so ::reprocedure would fail.  Maybe
> Andrey's way is better (checking proname rather than its OID).

proname is dangerous, because there's nothing stopping users from
adding more functions with the same name.

Just use a server-version-dependent list of regprocedure OIDs.

			regards, tom lane

Commits

  1. doc: add PG 14 relnote item about array function references

  2. Work around cross-version-upgrade issues created by commit 9e38c2bb5.