Re: BUG #17486: [pg_restore] Restoring a view fails if this view contains an attribute without alias name.
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: n.lutic@loxodata.com, pgsql-bugs@lists.postgresql.org
Date: 2022-05-20T15:19:33Z
Lists: pgsql-bugs
Attachments
- tweak-ruleutils-column-name-rule.patch (text/x-diff) patch
- regression.diffs (text/x-diff) patch
Daniel Gustafsson <daniel@yesql.se> writes: >> On 20 May 2022, at 16:34, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Perhaps we should just tweak ruleutils so that the alias is always >> printed for non-Var columns, even when it's "?column?". That's kind of >> ugly, but if you wanted non-ugly you should have selected a better column >> name to start with. > That might be the path of least confusion, and as you rightly say, if you don't > like the ugliness then there is a very easy way to fix it. Hmm ... it's a very easy code change, but it results in a lot of changes in the regression tests (and I've only tried the core tests so far). Given the lack of prior complaints, I wonder if it's going to be worth this much behavioral churn. It'd be better if we could do this only when the name is actually referenced somewhere, but I don't think that's an easy thing to determine. regards, tom lane
Commits
-
Show 'AS "?column?"' explicitly when it's important.
- fefd5463173a 13.8 landed
- f3b8d7244ae1 11.17 landed
- c7461fc25558 15.0 landed
- bb2c04676be0 12.12 landed
- 7686403b43ca 10.22 landed
- 6f7eec1193f8 14.4 landed