Re: Little cleanup of ShmemInit function names

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Andreas Karlsson <andreas@proxel.se>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2024-08-28T18:44:36Z
Lists: pgsql-hackers
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 28/08/2024 18:26, Andreas Karlsson wrote:
>> Small typo with the extra "which" which makes the sentence not flow
>> correctly
>> "This is called from CreateSharedMemoryAndSemaphores(), which see for
>> more comments."

> Hmm, I don't see the issue. It's an uncommon sentence structure, but it 
> was there before this patch, and it's correct AFAICS. If you grep for 
> "which see ", you'll find some more examples of that.

I didn't check the git history for this particular line, but at least
some of those examples are mine.  I'm pretty certain it's good English.

			regards, tom lane



Commits

  1. Rename some shared memory initialization routines

  2. Refactor lock manager initialization to make it a bit less special