Re: BUG #18240: Undefined behaviour in cash_mul_flt8() and friends
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: David Rowley <dgrowleyml@gmail.com>, exclusion@gmail.com,
pgsql-bugs@lists.postgresql.org
Date: 2023-12-16T15:19:18Z
Lists: pgsql-bugs
Michael Paquier <michael@paquier.xyz> writes: > On Tue, Dec 12, 2023 at 09:37:58AM -0500, Tom Lane wrote: >> ... Perhaps we could allow extension >> modules to use binary_upgrade_set_next_pg_type_oid, and then somehow >> reserve the money and _money OIDs forever? > Now, I am not sure that we're making users a favor in keeping around a > data type that's kind of obsolete these days, particularly when all of > them basically require handling of fractional cents when doing serious > calculations. That's a trap in disguise, even if tying data to a > locale for the unit sounds appealing for some applications. Yeah, I wouldn't propose this if money were the only type we were thinking of getting rid of; likely not worth the trouble. But I've got one eye on the geometric types as well --- I think it would be great all around if we could kick those out of the core distribution and let them be maintained independently. But I fear we can't do that without some method whereby pg_upgrade is still possible across the change. regards, tom lane
Commits
-
Add overflow checks to money type.
- e8dfe0430fad 14.13 landed
- c5321e9651c5 13.16 landed
- b82791c8fc2c 15.8 landed
- 4f962815871f 12.20 landed
- 3764ee47f78c 17.0 landed
- 34e9dce69c46 16.4 landed
- 22b0ccd65d27 18.0 landed
-
Reduce dependency to money data type in main regression test suite
- 31acee4b66f9 17.0 landed