Horton

Re: Extra Vietnamese unaccent rules

Dang Minh Huong <kakalot49@gmail.com>

View thread View on postgr.es
From: Dang Minh Huong <kakalot49@gmail.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>, Kha Nguyen <nlhkha@gmail.com>
Cc: Michael Paquier <michael.paquier@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-06-03T15:43:17Z
Lists: pgsql-hackers 
> On May 30, 29 Heisei, at 00:22, Dang Minh Huong <kakalot49@gmail.com> wrote:
> 
> 
> 
>> On May 29, 29 Heisei, at 10:47, Thomas Munro <thomas.munro@enterprisedb.com <mailto:thomas.munro@enterprisedb.com>> wrote:
>> 
>> On Sun, May 28, 2017 at 7:55 PM, Dang Minh Huong <kakalot49@gmail.com <mailto:kakalot49@gmail.com>> wrote:
>>> Thanks for reporting and lecture about unicode.
>>> I attached a patch as the instruction from Thomas. Could you confirm it.
>> 
>> -           is_plain_letter(table[codepoint.combining_ids[0]]) and \
>> +           (is_plain_letter(table[codepoint.combining_ids[0]]) or\
>> +            len(table[codepoint.combining_ids[0]].combining_ids) > 1) and \
>> 
>> Shouldn't you use "or is_letter_with_marks()", instead of "or len(...)
>>> 1"?  Your test might catch something that isn't based on a 'letter'
>> (according to is_plain_letter).  Otherwise this looks pretty good to
>> me.  Please add it to the next commitfest.
> 
> Thanks for confirm, sir.
> I will add it to the next CF soon.

Sorry for lately response. I attach the update patch.

---
Thanks and best regards,
Dang Minh Huong

Commits

  1. Extend the default rules file for contrib/unaccent with Vietnamese letters.