Re: type in basebackup_incremental.c ?

On 2024-04-11 Th 06:15, Daniel Gustafsson wrote:
>> On 11 Apr 2024, at 11:49, Daniel Westermann (DWE) <daniel.westermann@dbi-services.com> wrote:
>>
>> Hi,
>>
>> /*
>>   * we expect the find the last lines of the manifest, including the checksum,
>>   * in the last MIN_CHUNK bytes of the manifest. We trigger an incremental
>>   * parse step if we are about to overflow MAX_CHUNK bytes.
>>   */
>>
>> Shouldn't this be:
>> /*
>>   * we expect to find the last lines of the manifest,...
>>   */
> That sounds about right, and since it's a full sentence it should also start
> with a capital 'W': "We expect to find the..".
>

Thanks, I will include that in the cleanups I'm intending to push today.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com