Horton

Re: Add two missing tests in 035_standby_logical_decoding.pl

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread View on postgr.es
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-04-17T10:21:20Z
Lists: pgsql-hackers 
Hi,

On 4/17/23 11:55 AM, Alvaro Herrera wrote:
> On 2023-Apr-12, Drouvot, Bertrand wrote:
> 
>> I'm not sure if adding those 2 tests should be considered as an open
>> item. I can add this open item if we think that makes sense. I'd be
>> happy to do so but it looks like I don't have the privileges to edit
>> https://wiki.postgresql.org/wiki/PostgreSQL_16_Open_Items
> 
> I think adding extra tests for new code can definitely be considered an
> open item, since those tests might help to discover issues in said new
> code.
> 

Thanks for the feedback! Added as an open item.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

  1. Fix the race condition in the test case added by commit a6e04b1d20.

  2. Test that invalidated logical slots doesn't retain WAL.

  3. Add a test to verify that subscription to the standby works.

  4. Reduce the log level in 035_standby_logical_decoding.pl.