Horton

Re: PXGS vs TAP tests

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Noah Misch <noah@leadboat.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-06-20T17:24:04Z
Lists: pgsql-hackers

Attachments

On 6/20/21 10:56 AM, Andrew Dunstan wrote:
> On 6/20/21 10:45 AM, Tom Lane wrote:
>
>>> I removed the REGRESS_SHLIB setting altogether for the PGXS case - it's
>>> not clear to me why we need it in a TAP test recipe at all.
>> After some digging in the git history, it looks like it's there because
>> of Noah's c09850992, which makes me wonder whether 017_shm.pl requires
>> it.  If so, it'd make more sense perhaps for that one test script
>> to set up the environment variable than to have it cluttering every TAP
>> run.
>
> Yeah, I'll do some testing.
>
>
>

Tests pass with the attached patch, which puts the setting in the
Makefile for the recovery tests. The script itself doesn't need any
changing.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

  1. Fix prove_installcheck to use correct paths when used with PGXS