Re: Unnecessary use of .* in examples
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: rmzgrimes@gmail.com, pgsql-docs@lists.postgresql.org
Date: 2021-02-01T15:08:52Z
Lists: pgsql-docs
Laurenz Albe <laurenz.albe@cybertec.at> writes: > On Mon, 2021-02-01 at 05:46 +0000, PG Doc comments form wrote: >> In the table for the ~ (and friends) operator, every example has a pointless >> set of '.*' surrounding the text to be matched. These unnecessary operators >> add visual clutter making the examples both harder to read and understand, >> and since they're official examples, they teach bad habits. > I agree that that is comewhat confusing for people who understand > regular expressions. On the other hand, the example should show some > special characters, so that people who don't know regular expressions > understand that this is more than substring matching. > Perhaps 'thomas' ~ '^thom' and so on? There are examples just a bit further down that include special characters. I agree with the OP that the useless ".*"s add nothing except confusion as to the semantics; but I don't think we need these very first examples to use a lot of bells and whistles. Maybe what would be better is to have an example with embedded .* such as 'thomas' ~ 't.*m'. regards, tom lane
Commits
-
Doc: work a little harder on the initial examples for regex matching.
- dae5af6c19f2 13.2 landed
- 9522085ac917 14.0 landed