Re: .gitignore files, take two
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2010-09-21T15:27:38Z
Lists: pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes: > Breaking it up was quite trivial. Here's what I came up with after > building on my box. I'm sure there are some on other platforms showing > up, but this should be the majority. > I just realized it does not include contrib, but's that a mechanical > copy of the same thing. > So if we want to go with this way, i have the scripts/changes ready :) This works for me, modulo some things: If we are going to ignore *.so at the top level, we also need to ignore *.sl (for HPUX) and *.dll (for Windows). I also wonder why we have entries like this: > +libecpg.a > +libecpg.so.* rather than global ignore patterns for *.a and *.so.[0-9] We should probably ignore src/Makefile.custom, since that is still a supported way to customize builds (and some of us still use it). > diff --git a/src/timezone/.gitignore b/src/timezone/.gitignore > new file mode 100644 > index 0000000..f844c9f > --- /dev/null > +++ b/src/timezone/.gitignore > @@ -0,0 +1 @@ > +/zic Why does this entry have a / when none of the rest do? Shouldn't we be consistent about that? regards, tom lane