Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c

Euler Taveira <euler@eulerto.com>

From: "Euler Taveira" <euler@eulerto.com>
To: "Bossart, Nathan" <bossartn@amazon.com>, "Bharath Rupireddy" <bharath.rupireddyforpostgres@gmail.com>, "PostgreSQL Hackers" <pgsql-hackers@lists.postgresql.org>
Date: 2021-09-13T01:14:36Z
Lists: pgsql-hackers
On Sun, Sep 12, 2021, at 8:02 PM, Bossart, Nathan wrote:
> nitpick: It looks like there's an extra set of parentheses around
> errmsg().
Indeed. Even the requirement for extra parenthesis around auxiliary function
calls was removed in v12 (e3a87b4991cc2d00b7a3082abb54c5f12baedfd1).


--
Euler Taveira
EDB   https://www.enterprisedb.com/

Commits

  1. Remove code duplication for permission checks with replication slots

  2. Re-implement the ereport() macro using __VA_ARGS__.