Re: backup manifests and contemporaneous buildfarm failures
Tom Lane <tgl@sss.pgh.pa.us>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Try to avoid compiler warnings in optimized builds.
- 05021a2c0cd2 13.0 landed
-
Fix option related issues in pg_verifybackup.
- 0a89e93bfaa6 13.0 landed
-
Add index term for backup manifest in documentation.
- 4db819ba4039 13.0 landed
-
Code review for backup manifest.
- a2ac73e7be7a 13.0 landed
-
Document the backup manifest file format.
- 149f2ae88ab0 13.0 landed
-
Fix typo in pg_validatebackup documentation.
- c4f82a779d26 13.0 landed
-
Exclude backup_manifest file that existed in database, from BASE_BACKUP.
- 1ec50a81ec0a 13.0 landed
-
Msys2 tweaks for pg_validatebackup corruption test
- c3e4cbaab936 13.0 landed
-
Fix resource management bug with replication=database.
- 3e0d80fd8d3d 13.0 cited
-
Be more careful about time_t vs. pg_time_t in basebackup.c.
- db1531cae009 13.0 cited
-
pg_validatebackup: Fix 'make clean' to remove tmp_check.
- 9f8f881caa0f 13.0 landed
-
pg_validatebackup: Also use perl2host in TAP tests.
- 460314db08e8 13.0 landed
-
Generate backup manifests for base backups, and validate them.
- 0d8c9c1210c4 13.0 landed
-
Add checksum helper functions.
- c12e43a2e0d4 13.0 landed
-
pg_waldump: Add a --quiet option.
- ac44367efbef 13.0 landed
-
Catversion bump for b9b408c48724
- afb5465e0cfc 13.0 cited
-
pg_basebackup: Refactor code for reading COPY and tar data.
- 431ba7bebf13 13.0 landed
-
Use a ResourceOwner to track buffer pins in all cases.
- 3cb646264e8c 12.0 cited
-
Use ARMv8 CRC instructions where available.
- f044d71e331d 11.0 cited
-
Logical replication support for initial data copy
- 7c4f52409a8c 10.0 cited
-
Use Intel SSE 4.2 CRC instructions where available.
- 3dc2d62d0486 9.5.0 cited
-
Switch to CRC-32C in WAL and other places.
- 5028f22f6eb0 9.5.0 cited
-
Remove support for 64-bit CRC.
- 404bc51cde9d 9.5.0 cited
-
Change CRCs in WAL records from 64bit to 32bit for performance reasons.
- 21fda22ec46d 8.1.0 cited
Robert Haas <robertmhaas@gmail.com> writes: > On Sat, Apr 4, 2020 at 10:57 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> What is odd is that >> (AFAIR) we've never seen this before. Maybe somebody recently added >> an error cursor callback in a place that didn't have it before, and >> is involved in SQL-function processing? None of the commits leading >> up to the earlier failure look promising for that, though. > The relevant range of commits (e8b1774fc2 to a7b9d24e4e) includes an > ereport change (bda6dedbea) and a couple of "simple expression" > changes (8f59f6b9c0, fbc7a71608) but I don't know exactly why they > would have caused this. When I first noticed hyrax's failure, some days ago, I immediately thought of the "simple expression" patch. But that should not have affected SQL-function processing in any way: the bulk of the changes were in plpgsql, and even the changes in plancache could not be relevant, because functions.c does not use the plancache. As for ereport, you'd think that that would only matter once you were already doing an ereport. The point at which the stack overflow check triggers should be in normal code, not error recovery. > It seems at least possible, though, that > changing the return type of functions involved in error reporting > would slightly change the amount of stack space used; Right, but if it's down to that sort of phase-of-the-moon codegen difference, you'd think this failure would have been coming and going for years. I still suppose that some fairly recent change must be contributing to this, but haven't had time to investigate. > Other than experimenting on > that machine, I'm not sure how we could really determine the relevant > factors here. We don't have a lot of CCA buildfarm machines, so I'm suspecting that it's probably not that hard to repro if you build with CCA. regards, tom lane