Re: BUG #15827: Unable to connect on Windows using pg_services.conf using Python psycopg2
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Jorge Gustavo Rocha <jgr@geomaster.pt>, pgsql-bugs@lists.postgresql.org
Date: 2019-06-21T00:48:33Z
Lists: pgsql-bugs
Michael Paquier <michael@paquier.xyz> writes: > Thanks for testing. It seems to me that the current behavior is just > annoying, so there is a good argument for back-patching. Now it is > true that we have had few complaints on the matter over the years, and > usually in those cases we bother only about HEAD. I would still do a > back-patch in this case. Any Thoughts from others? I'm still of the opinion that (1) it's very weird that this code allows for leading space on a line but not trailing space; (2) we need to look for other places where we have the same issue. Possibly libpq is the only chunk of our code that's at serious risk, since we don't change the default binary mode in the backend. But even if you assume that that's true, this isn't the only config file that libpq examines. regards, tom lane
Commits
-
Fix failures to ignore \r when reading Windows-style newlines.
- 8c52b77ddea7 9.4.24 landed
- 6266654db7fa 9.5.19 landed
- ba27151d1eb0 9.6.15 landed
- cb65b454f87b 10.10 landed
- 11a0a4db3cdb 11.5 landed
- c58cf97f2fc4 12.0 landed
- b654714f9bcf 13.0 landed