Horton

fix crash with Python 3.11

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-12-22T08:24:06Z
Lists: pgsql-hackers

Attachments

This patch needs another close pass and possibly some refactoring to 
avoid copy-and-paste, but I'm putting this out here, since people are 
already testing with Python 3.11 and will surely run into this problem.

The way plpy.commit() and plpy.rollback() handle errors is not ideal. 
They end up just longjmping back to the main loop, without telling the 
Python interpreter about it.  This hasn't been a problem so far, 
apparently, but with Python 3.11-to-be, this appears to cause corruption 
in the state of the Python interpreter.  This is readily reproducible 
and will cause crashes in the plpython_transaction test.

The fix is that we need to catch the PostgreSQL error and turn it into a 
Python exception, like we do for other places where plpy.* methods call 
into PostgreSQL internals.

Commits

  1. Re-add SPICleanup for ABI compatibility in stable branch

  2. Fix SPI's handling of errors during transaction commit.

  3. Don't use static storage for SaveTransactionCharacteristics().