Horton

Re: BUG #18483: Segmentation fault in tests modules

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, a.kozhemyakin@postgrespro.ru, pgsql-bugs@lists.postgresql.org, Masahiko Sawada <sawada.mshk@gmail.com>, johncnaylorls@gmail.com
Date: 2024-06-08T15:07:23Z
Lists: pgsql-bugs 
Alexander Lakhin <exclusion@gmail.com> writes:
> May I ask you about the project policy regarding such test modules
> failures?
> Do you think all of these should be fixed or it's ok to have some
> server-crashing modules in the tree?

I don't think there's a one-size-fits-all policy for them.  Since
we don't intend these modules to be installed, they don't really
need to work in any cases beyond the ones exercised in the tests.
Still, if it's easy to stop a misbehavior then we probably should.
The test_predtest problem was just a missing check-for-null so
I definitely regard that as worth fixing.  These other ones would
have to be investigated enough to figure out the size of the fix
before I'd venture an opinion.

			regards, tom lane

Commits

  1. Make regress function make_tuple_indirect() able to handle plain attributes

  2. Fix segmentation fault in test_tidstore.

  3. Tighten test_predtest's input checks, and improve error messages.