Horton

Re: LLVM strip -x fails

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>, Palle Girgensohn <girgen@pingpong.net>, pgsql-hackers@postgresql.org
Date: 2023-04-21T17:30:31Z
Lists: pgsql-hackers 
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 21.04.23 19:00, Tom Lane wrote:
>> If you use both -x and -S, you get the same file sizes as with -x
>> alone.  Not sure why we should change anything here.

> The complaint was that -x doesn't work correctly, no?

The complaint was that it doesn't work correctly if you are using
llvm-strip.  However, llvm-strip will be picked up by the previous
test for GNU strip, independently of what platform you're on.
The code in question here is only concerned with Apple's strip.

			regards, tom lane

Commits

  1. Use --strip-unneeded when stripping static libraries with GNU strip.

  2. Add make install-strip target.