Horton

Re: segmentation fault when cassert enabled

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Amit Kapila <amit.kapila16@gmail.com>, vignesh C <vignesh21@gmail.com>, Petr Jelinek <petr.jelinek@2ndquadrant.com>
Cc: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Peter Geoghegan <pg@bowt.ie>
Date: 2019-12-16T12:27:43Z
Lists: pgsql-hackers 
On 2019-12-16 11:11, Amit Kapila wrote:
> I agree that this is a timing issue.  I also don't see a way to write
> a reproducible test for this.  However, I could reproduce it via
> debugger consistently by following the below steps.  I have updated a
> few comments and commit messages in the attached patch.
> 
> Peter E., Petr J or anyone else, do you have comments or objections on
> this patch?  If none, then I am planning to commit (and backpatch)
> this patch in a few days time.

The patch seems fine to me.  Writing a test seems hard.  Let's skip it.

The commit message has a duplicate "building"/"built" in the first sentence.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Fix subscriber invalid memory access on DDL.

  2. Fix memory allocation mistake