Re: killing perl2host
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-02-17T19:40:01Z
Lists: pgsql-hackers
On 2/17/22 13:10, Andres Freund wrote:
> On 2022-02-17 13:08:01 -0500, Andrew Dunstan wrote:
>>>> perhaps something like:
>>>>
>>>>
>>>> my $msystem = $ENV{MSYSTEM} || 'undef';
>>>>
>>>> die "incompatible perl" if $Config{osname} eq 'msys' && $msystem ne
>>>> 'MSYS';
>>> Why tests MSYSTEM instead of $host_os?
>> Is that available in check_modules.pl? AFAICT it's an unexported shell
>> variable.
> No, but it could just be passed to it?
Sure, that could be done, but what's the issue? Msys2 normally defines
MSYSTEM for you - see /etc/msystem which is sourced by /etc/profile.
> Or the test just implemented in
> configure, as I suggested.
>
No, because we don't know which perl will be invoked by $PROVE. That's
why we set up check_modules.pl in the first place.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Commits
-
Remove PostgreSQL::Test::Utils::perl2host completely
- 95d981338b24 15.0 landed
- b30c62bd42eb 10.21 landed
- b4a6ceed52ee 11.16 landed
- 8358eacc954d 12.11 landed
- c27aa21e0dc8 13.7 landed
- 652ff988fbf6 14.3 landed
-
Remove most msys special processing in TAP tests
- 1c6d4629394d 15.0 landed
- f1f82301d6c5 11.16 landed
- aa8d4137f990 12.11 landed
- a5716baac00b 13.7 landed
- 8b5cd373ba03 14.3 landed
- 2b02cadb5cbc 10.21 landed
-
Ensure the right perl is used for TAP tests on msys
- cf12541f2bd5 15.0 landed
-
Disable perl2host() processing in TAP tests
- f1ac4a74dee5 15.0 landed