Horton

Re: PATCH: Batch/pipelining support for libpq

Daniel Verite <daniel@manitou-mail.org>

View thread View on postgr.es
From: "Daniel Verite" <daniel@manitou-mail.org>
To: "Vaishnavi Prabakaran" <vaishnaviprabakaran@gmail.com>
Cc: "Michael Paquier" <michael.paquier@gmail.com>,"Prabakaran, Vaishnavi" <VaishnaviP@fast.au.fujitsu.com>,"Craig Ringer" <craig@2ndquadrant.com>,"Haribabu Kommi" <kommi.haribabu@gmail.com>,"Tsunakawa, Takayuki" <tsunakawa.takay@jp.fujitsu.com>,"Dmitry Igrishin" <dmitigr@gmail.com>,"Andres Freund" <andres@anarazel.de>,"PostgreSQL Hackers" <pgsql-hackers@postgresql.org>,"Manuel Kniep" <m.kniep@web.de>,"fujita.etsuro@lab.ntt.co.jp" <fujita.etsuro@lab.ntt.co.jp>,"Iwata, Aya" <iwata.aya@jp.fujitsu.com>
Date: 2017-03-30T18:12:14Z
Lists: pgsql-hackers 
	Vaishnavi Prabakaran wrote:

> Hmm, With batch mode, after sending COPY command to server(and server
> started processing the query and goes into COPY state) , client does not
> immediately read the result , but it keeps sending other queries to the
> server. By this time, server already encountered the error
> scenario(Receiving different message during COPY state) and sent error
> messages

IOW, the test intentionally violates the protocol and then all goes wonky
because of that.
That's why I was wondering upthread what's it's supposed to test.
I mean, regression tests are meant to warn against a desirable behavior
being unknowingly changed by new code into an undesirable behavior.
Here we have the undesirable behavior to start with.
What kind of regression could we fear from that?

Best regards,
-- 
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite

Commits

  1. Add libpq pipeline mode support to pgbench

  2. Implement pipeline mode in libpq