Horton

Re: Crash in record_type_typmod_compare

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Sait Talha Nisanci <Sait.Nisanci@microsoft.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Metin Doslu <Metin.Doslu@microsoft.com>
Date: 2021-03-31T19:34:22Z
Lists: pgsql-hackers 
Andres Freund <andres@anarazel.de> writes:
> On 2021-03-31 13:10:50 -0400, Tom Lane wrote:
>> Couldn't we just
>> teach record_type_typmod_compare to say "not equal" if it sees a
>> null tupdesc?

> Won't that lead to an accumulation of dead hash table entries over time?

Yeah, if you have repeat failures there, which doesn't seem very likely.
Still, I take your point that we're doing it the first way in other
places, so maybe inventing a different way here isn't good.

			regards, tom lane

Commits

  1. Fix assign_record_type_typmod().

  2. Improve an error message