Horton

Re: Changing the state of data checksums in a running cluster

Tomas Vondra <tomas@vondra.me>

View thread
From: Tomas Vondra <tomas@vondra.me>
To: Andreas Karlsson <andreas@proxel.se>, Daniel Gustafsson <daniel@yesql.se>
Cc: Bernd Helmle <mailings@oopsware.de>, Michael Paquier <michael@paquier.xyz>, Michael Banck <mbanck@gmx.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-20T10:34:14Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Use correct datatype for PID

  2. Improve comments in online checksums code

  3. Fix checksum state transition during promotion

  4. Fix regex searching for page verification failures in tests

  5. Apply data-checksum worker throttling parameters

  6. Skip WAL for unlogged main fork during online checksum enable

  7. Revert "Get rid of WALBufMappingLock"

  8. Get rid of WALBufMappingLock

  9. Improve grammar of options for command arrays in TAP tests

On 11/19/25 22:03, Andreas Karlsson wrote:
> Hi,
> 
> I have been following these discussions but not read the patch in detail.
> 
> This patch makes me worried especially with the new issues recently
> uncovered. This was already a quite big patch and to fix these issues it
> will likely have to become even bigger and given how this would become a
> very rarely stressed code paths I wonder if we can actually ever become
> confident that the patch works in all edge cases.
> 
> Something like this need to be easy to understand for us to have any
> hope at all to be comfortable in the correctness. Can we actually do that?
> 

How's this different from any other complex patch? We get more familiar
with the problem during review, identify issues, improve the patch to
address them. And then again and again.

Of course, it'd be great to have a perfect understanding of the problem
from the very beginning, but that's not always possible. And I can't
guarantee we'll find/fix all issues.


regards

-- 
Tomas Vondra