Horton

Re: [sqlsmith] Failed assertion during partition pruning

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Zhihong Yu <zyu@yugabyte.com>, Andreas Seltenreich <seltenreich@gmx.de>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2021-02-01T05:48:57Z
Lists: pgsql-hackers 
David Rowley <dgrowleyml@gmail.com> writes:
> What I can't understand is why you changed to a List-of-Lists rather
> than a List-of-Relids.

Yeah, I spent no effort on micro-optimizing the data structure.  I figured
that since we were not including leaf partitions, there would never be
enough rels involved to worry about.  Perhaps that's wrong though.

> Parent RT indexes are guaranteed to be lower than their children RT
> indexes,

I was intentionally avoiding that assumption ;-).  Maybe it buys enough
to be worth the loss of generality, but ...

			regards, tom lane

Commits

  1. Remove [Merge]AppendPath.partitioned_rels.

  2. Remove incidental dependencies on partitioned_rels lists.

  3. Revise make_partition_pruneinfo to not use its partitioned_rels input.

  4. Fix two issues in TOAST decompression.