Horton

Re: daitch_mokotoff module

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Dag Lem <dag@nimrod.no>, Tomas Vondra <tomas.vondra@enterprisedb.com>, Andres Freund <andres@anarazel.de>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Paul Ramsey <pramsey@cleverelephant.ca>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-04-08T03:03:17Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Avoid using non-ASCII commentary in daitch_mokotoff.c.

  2. Remove some non-ASCII symbols from a comment.

  3. Remove useless dependencies in daitch_mokotoff_header.pl.

  4. Pacify perlcritic.

  5. Add support for Daitch-Mokotoff Soundex in contrib/fuzzystrmatch.

  6. Enable routine running of citext's UTF8-specific test cases.

Andrew Dunstan <andrew@dunslane.net> writes:
> On 2023-04-07 Fr 21:52, Tom Lane wrote:
>> pipit appears to be running a reasonably current system (RHEL8), so
>> the claim that "open" is a Perl core module appears false.  We need
>> to rewrite this to not use that.

> I think it is a core module (See <https://metacpan.org/pod/open>) but it 
> appears that some packagers have separated it out for reasons that 
> aren't entirely obvious:

Hmm, yeah: on my RHEL8 workstation

$ rpm -qf /usr/share/perl5/open.pm
perl-open-1.11-421.el8.noarch

It's not exactly clear how that came to be installed, because

$ rpm -q perl-open --whatrequires
no package requires perl-open

and indeed another nearby RHEL8 machine doesn't have that package
installed at all, even though I've got it loaded up with enough
stuff for most Postgres work.  (Sadly, I'd not tested on that one.)

Anyway, I assume this is just syntactic sugar for something
we can do another way?  If it's at all fundamental, I'll have
to back the patch out.

			regards, tom lane