Re: PostgreSQL does not compile on macOS SDK 15.0
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
Aleksander Alekseev <aleksander@timescale.com>,
Pg Hackers <pgsql-hackers@lists.postgresql.org>,
Stan Hu <stanhu@gmail.com>
Date: 2024-07-04T18:37:50Z
Lists: pgsql-hackers
Thomas Munro <thomas.munro@gmail.com> writes: > On Mon, Jul 1, 2024 at 2:06 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Yeah. I'd do pg_regex_t in a minute except that it'd break existing >> extensions using our facilities. However, your mention of macrology >> stirred an idea: could we have our regex/regex.h intentionally >> #include the system regex.h and then do >> #define regex_t pg_regex_t >> ? > Good idea. Here's an attempt at that. I think it might be cleaner to put the new #include and macro hacking into regcustom.h, to show that it's our own hack and not part of the "official" Spencer code. OTOH, we do have to touch regex.h anyway to change the #include guards, and it's not like there are not any other PG-isms in there. So I'm not 100% sold that that way would be better --- what do you think? regards, tom lane
Commits
-
Cope with <regex.h> name clashes.
- 9c273679b36b 17.0 landed
- 31423bc4489d 16.4 landed
- 467d77bb1634 15.8 landed
- c2342a925b70 14.13 landed
- 440aedc0fb18 13.16 landed
- 274a8195d479 12.20 landed
- 2a5ef0983040 18.0 landed