Horton

Re: pgsql: Prefetch data referenced by the WAL, take II.

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>, Thomas Munro <tmunro@postgresql.org>, pgsql-committers@lists.postgresql.org
Date: 2022-04-07T13:53:43Z
Lists: pgsql-hackers 
Andrew Dunstan <andrew@dunslane.net> writes:
> On 4/7/22 04:36, Andres Freund wrote:
>> Or maybe it's the scripts that are screwed up? Because I don't see any error
>> checking in headerscheck/cpluspluscheck. And indeed, locally they show the
>> errors, but exit with 0.

> Yeah, you can't rely on the exit status, if they produce output that
> should be regarded as a failure (that's what crake does).

Yeah, those scripts were only intended to be run by hand.  If someone
feels like upgrading them to also produce a useful exit status,
I'm for it.

			regards, tom lane

Commits

  1. Improve wal_decode_buffer_size description some more

  2. Include some missing headers.

  3. Prefetch data referenced by the WAL, take II.