Horton

Re: Warning while compiling 19beta1

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: depesz@depesz.com
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2026-06-04T15:11:31Z
Lists: pgsql-bugs 
I wrote:
> hubert depesz lubaczewski <depesz@depesz.com> writes:
>> llvmjit.c: In function ‘llvm_split_symbol_name’:
>> llvmjit.c:1065:27: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>> 1065 |                 *funcname = strrchr(name, '.');
>> |                           ^

> Yeah, some of the buildfarm animals have been showing this for awhile.

Actually, after looking closer, the LLVM version isn't relevant.
What you need is a gcc new enough to know that the result of
strrchr() applied to a const char * should be considered const.

This function is ugly in some other ways too.  Will fix.

			regards, tom lane

Commits

  1. Fix another case of indirectly casting away const.

  2. Small terminology fixes in comments