Horton

Re: TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>, Andrew Gierth <andrew@tao11.riddles.org.uk>
Date: 2018-01-03T23:36:07Z
Lists: pgsql-hackers 
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> If there is any system where sizeof(FormData_pg_attribute) !=
> (offsetof(FormData_pg_attribute,attcollation) + sizeof(Oid)), won't
> load_relcache_init_file() get upset?  Oh, I see it would just go to
> read_failed and then "do it the hard way".

Right, so we needn't include a catversion bump (or more likely,
a RELCACHE_INIT_FILEMAGIC change) in that patch.

			regards, tom lane

Commits

  1. Clean up tupdesc.c for recent changes.

  2. Add support for coordinating record typmods among parallel workers.