Horton

Re: daitch_mokotoff module

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Dag Lem <dag@nimrod.no>, Tomas Vondra <tomas.vondra@enterprisedb.com>, Andrew Dunstan <andrew@dunslane.net>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Paul Ramsey <pramsey@cleverelephant.ca>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-04-08T01:27:47Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Avoid using non-ASCII commentary in daitch_mokotoff.c.

  2. Remove some non-ASCII symbols from a comment.

  3. Remove useless dependencies in daitch_mokotoff_header.pl.

  4. Pacify perlcritic.

  5. Add support for Daitch-Mokotoff Soundex in contrib/fuzzystrmatch.

  6. Enable routine running of citext's UTF8-specific test cases.

Andres Freund <andres@anarazel.de> writes:
> On 2023-04-07 21:13:43 -0400, Tom Lane wrote:
>> I pushed this after some mostly-cosmetic fiddling.  Most of the
>> buildfarm seems okay with it, but crake's perlcritic run is not:
>> 
>> ./contrib/fuzzystrmatch/daitch_mokotoff_header.pl: I/O layer ":utf8" used at line 15, column 5.  Use ":encoding(UTF-8)" to get strict validation.  ([InputOutput::RequireEncodingWithUTF8Layer] Severity: 5)

> Unless it's not available with old versions, using :encoding(UTF-8) seems
> sensible?

Yeah, that's the obvious fix, I was just wondering if people with
more perl-fu than I have see a problem with it.  But I'll go ahead
and push that for now.

			regards, tom lane