Horton

Re: pg_validatebackup -> pg_verifybackup?

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: David Steele <david@pgmasters.net>, Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Date: 2020-04-10T20:40:02Z
Lists: pgsql-hackers 
Andres Freund <andres@anarazel.de> writes:
> On 2020-04-10 16:13:18 -0400, Tom Lane wrote:
>> Well, we're not getting there for v13.  Are you proposing that this
>> patch just be reverted because it doesn't do everything at once?

> No. I suggest choosing a name that's compatible with moving more
> capabilities under the same umbrella at a later time (and I suggested
> the same pre freeze too). Possibly adding a toplevel --verify-manifest
> option as the only change besides naming.

It doesn't really seem like either name is problematic from that
standpoint?  "Verify backup" isn't prejudging what aspect of the
backup is going to be verified, AFAICS.

			regards, tom lane

Commits

  1. Rename pg_validatebackup to pg_verifybackup some more.

  2. Rename pg_validatebackup to pg_verifybackup.