Re: pgsql: Prevent instability in contrib/pageinspect's regression test.
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>
Date: 2022-11-21T19:12:49Z
Lists: pgsql-hackers
Attachments
- fix-pageinspect-parallel-markings.patch (text/x-diff) patch
I wrote: > I'll check to see if any sibling functions have the same issue, > and push a patch to adjust them. > Presumably the parallel labeling has to be fixed as far back as > it's marked that way (didn't look). Maybe we should push the > test change further back too, just to exercise this. Hmm, so this is easy enough to fix in HEAD and v15, as attached. However, there's a problem in older branches: their newest versions of pageinspect are older than 1.10, so this doesn't work as-is. We could imagine inventing versions like 1.9.1, and providing a script pageinspect--1.9--1.9.1.sql to do what's done here as well as (in later branches) pageinspect--1.9.1--1.10.sql that duplicates pageinspect--1.9--1.10.sql, and then the same again for 1.8 and 1.7 for the older in-support branches. That seems like an awful lot of trouble for something that there have been no field complaints about. I'm inclined to apply this in HEAD and v15, and revert the test change in v14, and call it good. regards, tom lane
Commits
-
Mark pageinspect's disk-accessing functions as parallel restricted.
- b8988cf1d0a7 15.2 landed
- aeaaf520f409 16.0 landed
-
Prevent instability in contrib/pageinspect's regression test.
- e2933a6e1179 16.0 cited
-
Set cutoff xmin more aggressively when vacuuming a temporary table.
- a7212be8b9e0 14.0 cited