Horton

Re: [PATCH] Allow complex data for GUC extra.

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bryan Green <dbryan.green@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-12-30T01:44:45Z
Lists: pgsql-hackers 
Bryan Green <dbryan.green@gmail.com> writes:
> One notable behavioral change: check hooks using GUC_EXTRA_IS_CONTEXT
> now use palloc() instead of guc_malloc(). The old approach with
> guc_malloc() allowed check hooks to return false on OOM, letting the
> caller handle it at the appropriate error level. With palloc() an OOM
> throws an immediate ERROR. This seemed like an acceptable tradeoff

Why?  It seems both inconsistent and unsafe.

			regards, tom lane