Why did commit 6271fceb8 enable debug logging for all TAP tests?
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Simon Riggs <simon@2ndquadrant.com>, Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2018-05-07T01:49:46Z
Lists: pgsql-hackers
I've been trying to trace down a slowdown in HEAD's regression tests compared to the v10 branch, and one thing I discovered is that there was a noticeable across-the-board slowdown in the TAP tests as a result of commit 6271fceb8; as much as 10% for the "scripts" tests, though less in other places. The changes it made in xlog.c cannot explain that; it has to be down to this: diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm index 93faadc20e..80f68df246 100644 --- a/src/test/perl/PostgresNode.pm +++ b/src/test/perl/PostgresNode.pm @@ -419,6 +419,7 @@ sub init print $conf "restart_after_crash = off\n"; print $conf "log_line_prefix = '%m [%p] %q%a '\n"; print $conf "log_statement = all\n"; + print $conf "log_min_messages = debug1\n"; print $conf "log_replication_commands = on\n"; print $conf "wal_retrieve_retry_interval = '500ms'\n"; print $conf "port = $port\n"; Now, that was neither mentioned in the commit message nor justified by any added test cases or scaffolding, so I'm assuming it was simply a mistake and should be reverted. Please confirm. regards, tom lane
Commits
-
Improve inefficient regexes in vacuumdb TAP test.
- da0b4c8a8add 10.5 landed
- c63913ca7d1d 11.0 landed
- 42e5a1b563da 9.5.14 landed
- 3d48654017aa 9.4.19 landed
- 36784e9147fa 9.6.10 landed
-
Undo extra chattiness of postmaster logs in TAP tests.
- 17551f1a21fa 11.0 landed
-
Add TIMELINE to backup_label file
- 6271fceb8a4f 11.0 cited